Add an OpenThread RCP firmware package based on openthread/ot-nrf528xx#39
Merged
ksperling-apple merged 4 commits intoproject-chip:mainfrom Feb 23, 2026
Merged
Conversation
This initial version targets the NRF528408 MDK dongle because the UF2 bootloader makes it very easy to flash with minimal tooling. Also add an otbr-rcp script for finding / managing USB RCPs and use it to add hot plugging support to the otbr-agent service. Miscellaneous improvements: - Avoid clobbering /etc/config/otbr-agent - Add default configuration for a 'thread' firewall zone - Minor patches to otbr-agent to improve RCP device handling
There was a problem hiding this comment.
Code Review
This pull request introduces an OpenThread RCP firmware package for the NRF52840 MDK dongle, which is a significant addition. The changes include a new prebuilt toolchain package, utilities for UF2 flashing, and substantial enhancements to the otbr-agent service for improved RCP device management, such as hot-plugging and automatic firmware updates. The overall implementation is well-structured and robust. I have identified one high-severity bug related to device property parsing in a shell script and a medium-severity issue concerning code clarity in the new UF2 utility. The rest of the changes look good.
ForemanZack-CableLabs
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This initial version targets the NRF528408 MDK dongle because the UF2
bootloader makes it very easy to flash with minimal tooling.
Also add an otbr-rcp script for finding / managing USB RCPs and use
it to add hot plugging support to the otbr-agent service.
Miscellaneous improvements: